Remove unused files#6130
Conversation
There was a problem hiding this comment.
I do not have whole visibility for the project so was not sure about this file. Also changing define may touch a lot of files.
There was a problem hiding this comment.
This was a general observation, more aimed at the WPF team.
There was a problem hiding this comment.
I took a quick look and NETCOREAPP5_0 does not seem to be used and constants for the current target framework are declared by default (Example: NET6_0 for net6 target framework). I think it's safe to remove this one as well.
|
CLA check seems to be failing. I do not know why. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The cla problem does not seem to be related to this PR, I have the same problem in my latest PR and there's bunch of PR with the same problem in dotnet/runtime. |
|
Somebody else should do a review? |
|
Seems native files are moved out from native folder to lib. This causes installer issues downstream. From: runtimes\win-x86\native To: lib\net7.0 cc: @singhashish-wpf |
|
@kant2002 I suggest you build before and after the change and compare binlogs (under .\artifacts\logs), and see what's causing this change. |
9bf73f1 to
dc09bd4
Compare
|
From what I see, this is comes down to old main from which I create this PR. #5974 this line has the fix (at least how I understand this) |
|
@vishalmsft can you take a look again on this change? |
|
@dipeshmsft what else needed for this PR to be merged? Itching to make future small improvements to WPF. |
|
Hey @kant2002 , we have started the test pass, as soon as it is finished, we will merge the PR. |
Just general cleanup.
This
dir.propsis leftover from previous build infra.makefiles also most likely do not used.