Skip to content

Skip LimiterTests.ManyWaitsStackUp#1355

Merged
MihaZupan merged 2 commits into
dotnet:mainfrom
MihaZupan:skip-limitertest-ManyWaitsStackUp
Nov 5, 2021
Merged

Skip LimiterTests.ManyWaitsStackUp#1355
MihaZupan merged 2 commits into
dotnet:mainfrom
MihaZupan:skip-limitertest-ManyWaitsStackUp

Conversation

@MihaZupan
Copy link
Copy Markdown
Member

@MihaZupan MihaZupan commented Nov 5, 2021

Another flaky test from Microsoft.Kubernetes.UnitTests (#1333).
Failed on main for #1341

Cleaning up CI for #1353

@MihaZupan MihaZupan added this to the YARP 1.0.0 milestone Nov 5, 2021
@MihaZupan MihaZupan requested a review from Tratcher as a code owner November 5, 2021 17:03
@Tratcher
Copy link
Copy Markdown
Member

Tratcher commented Nov 5, 2021

There's a flaky test protocol in aspnetcore that I'd like to use here as well.

  • File an issue with the failure details (test name, failure, logs, etc).
  • Link to that issue in the skip comment.

That way we remember to go back and investigate.

@MihaZupan
Copy link
Copy Markdown
Member Author

MihaZupan commented Nov 5, 2021

Opened #1357 for tracking

Copy link
Copy Markdown
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge this before your versioning pr if possible.

@MihaZupan MihaZupan merged commit 0472499 into dotnet:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants