Update samples#1361
Merged
Merged
Conversation
Tratcher
approved these changes
Nov 8, 2021
Member
Tratcher
left a comment
Tratcher
left a comment
There was a problem hiding this comment.
I will cherry-pick this change onto the release/1.0 branch
Why are these changes needed in the release/1.0 branch? I'd expect that to be limited to servicing at this point.
Member
Author
|
They are updates to the samples people will use with the 1.0 release Edit: Will be merged into |
This reverts commit db97560.
MihaZupan
added a commit
to MihaZupan/yarp
that referenced
this pull request
Nov 8, 2021
* Add 6.0 target to ReverseProxy.Auth.Sample * Update launchsettings profile names * Fix typos in samples * Fix which values are logged in metrics sample * Use RequestUtilities.MakeDestinationAddress to create the Uri in direct sample * Update getting started for 1.0.0 * Fix typo in direct sample * Revert "Add 6.0 target to ReverseProxy.Auth.Sample" This reverts commit db97560.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a 6.0 target to the Auth sample (leftover from Add net6.0 targets #972 (comment))launchSettings.jsonRequestUtilitiesin the direct sample when creating the UriI will cherry-pick this change onto the
release/1.0branchContributes to #1353