Add net6.0 targets#972
Merged
Merged
Conversation
Tratcher
reviewed
May 3, 2021
7d2cbe4 to
1f95ba6
Compare
Tratcher
reviewed
May 5, 2021
Member
Author
|
Bumped the SDK to Everything is now buildable and testable in 6.0, with the exception of the Auth Sample. That one is hitting the following error: |
2 tasks
Tratcher
approved these changes
May 13, 2021
MihaZupan
commented
May 13, 2021
| @@ -1,12 +1,11 @@ | |||
| { | |||
| "sdk": { | |||
| "version": "6.0.100-preview.3.21202.5" | |||
Member
Author
There was a problem hiding this comment.
While CI is happy with this, this should further wait for dotnet/sdk#17461 to be fixed so that we can continue working locally.
It was useful that we did this early to spot issues like the AspNetCore bug but it shouldn't be criticial to merge ASAP.
MihaZupan
commented
May 21, 2021
Comment on lines
+414
to
+415
| // Future 6.0 builds will contain the fix to these missing converters | ||
| //#if !NET6_0_OR_GREATER |
Member
Author
There was a problem hiding this comment.
@Tratcher this PR is now unblocked with the latest SDK+VS version.
I had to revert this #if until we start consuming future 6.0 builds with the json fix.
Tratcher
approved these changes
May 21, 2021
This was referenced Nov 8, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on dotnet/aspnetcore#32364 as some of the health check tests are hitting this.
Fixes #936