Merged
Conversation
MOON-CLJ
commented
Jan 4, 2018
| return u64toa(static_cast<uint64_t>(value), buffer); | ||
| return u64toa(u, buffer); | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
MOON-CLJ
force-pushed
the
little_fix
branch
17 times, most recently
from
c361f03 to
8ccbd76
Compare
MOON-CLJ
changed the title
MOON-CLJ
commented
Jan 17, 2018
|
|
||
|
|
||
| std::queue<struct ::iovec> m_requestKeys; | ||
| std::queue<struct iovec> m_requestKeys; |
Contributor
Author
There was a problem hiding this comment.
"struct iovec" "struct ::iovec" both exists in source code，leave "struct iovec"。
MOON-CLJ
force-pushed
the
little_fix
branch
5 times, most recently
from
401e3e6 to
a472d9f
Compare
Contributor
Author
|
ping @mckelvin i want to know how do you think about this pr? should i split four commit to four prs? |
Conflicts: include/ConnectionPool.h src/ConnectionPool.cpp
Contributor
Author
|
ping @mckelvin |
Contributor
|
LGTM |
youngsofun
approved these changes
Mar 27, 2018
tclh123
added a commit
that referenced
this pull request
Feb 18, 2019
ChangeLog: - use pickle protocol version 2 (#52) - fix rvalue reference (#53) - Fix tests (#55) - golibmc_test: Fix fragile test case (#56) - Use connection pool in golibmc(again) (#57) - golibmc Quit ret err (#59) - cmake: Incorporate gtest in a standard way (#58) - Rename refactor (#60) - sync rapidjson/itoa.h upstream fix (#65) - split cppcheck (#67) - split FSM_GET_BYTES_CAS (#68) - Avoid noisy recv_err when broadcast quit (#73) - Try to support updating some servers without affecting others (#74) - make normalize_key cpdef & add warnings for unpickle unmarshal fail (#66) - fix fcntl usage when set socket nonblock (#69) - minor fix (#61) - add condition log macro (#77) - Define and use notWaitForRetryTimeout (#82) - upgrade travis to gcc 7 (#91) - add func errCodeToString (#79) - Introduce a reconnect mechanism in waitPoll (#88)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @everpcpc