Merged
Conversation
Contributor
Author
|
travis的setuptools有点问题，https://travis-ci.org/douban/libmc/jobs/385622435 。 |
MOON-CLJ
force-pushed
the
errCodeToString
branch
3 times, most recently
from
420fb80 to
0a9bd6f
Compare
tclh123
reviewed
Jan 25, 2019
src/Client.cpp
Outdated
| case RET_INCOMPLETE_BUFFER_ERR: | ||
| return keywords::kINCOMPLETE_BUFFER_ERROR; | ||
| default: | ||
| return "ok"; |
Contributor
There was a problem hiding this comment.
Add case RET_OK: and default return "unknown" ?
tclh123
reviewed
Jan 25, 2019
.travis.yml
Outdated
| install: | ||
| - if [[ $TEST_SUITE != "cppcheck" ]]; then pip install --upgrade pip setuptools; fi | ||
| # FIXME tmp install twice, because travis.ci encounter https://github.com/pypa/setuptools/issues/523#issuecomment-337482959 | ||
| - if [[ $TEST_SUITE != "cppcheck" ]]; then pip install --ignore-installed setuptools; fi |
Contributor
There was a problem hiding this comment.
leave .travis.yml unchanged? not seeing an error like this now.
Contributor
Author
There was a problem hiding this comment.
yes, i'll revert it
MOON-CLJ
force-pushed
the
errCodeToString
branch
from
0a9bd6f to
473d3fe
Compare
MOON-CLJ
force-pushed
the
errCodeToString
branch
from
473d3fe to
24a55c5
Compare
Contributor
Author
|
@tclh123 updated |
Contributor
|
There's a typo in commit messages |
Contributor
Author
so strict? should i fix it ? |
tclh123
reviewed
Jan 25, 2019
include/Client.h
Outdated
| std::vector<unsigned_result_t*> m_outUnsignedResultPtrs; | ||
| }; | ||
|
|
||
| const char* errCodeToString(err_code_t err); |
Contributor
There was a problem hiding this comment.
maybe move errCodeToString to Common.h ?
src/c_client.cpp
Outdated
|
|
||
|
|
||
| using douban::mc::Client; | ||
| using douban::mc::errCodeToString; |
Contributor
Author
There was a problem hiding this comment.
@tclh123 rm this line seems also works。but do you know why?
Contributor
Author
There was a problem hiding this comment.
okay there is some "Client" usage in c_client.cpp。
Contributor
It's quick to fix this. |
MOON-CLJ
force-pushed
the
errCodeToString
branch
from
24a55c5 to
c27d7da
Compare
Contributor
Author
|
updated |
mckelvin
approved these changes
Jan 26, 2019
tclh123
approved these changes
Jan 26, 2019
tclh123
added a commit
that referenced
this pull request
Feb 18, 2019
ChangeLog: - use pickle protocol version 2 (#52) - fix rvalue reference (#53) - Fix tests (#55) - golibmc_test: Fix fragile test case (#56) - Use connection pool in golibmc(again) (#57) - golibmc Quit ret err (#59) - cmake: Incorporate gtest in a standard way (#58) - Rename refactor (#60) - sync rapidjson/itoa.h upstream fix (#65) - split cppcheck (#67) - split FSM_GET_BYTES_CAS (#68) - Avoid noisy recv_err when broadcast quit (#73) - Try to support updating some servers without affecting others (#74) - make normalize_key cpdef & add warnings for unpickle unmarshal fail (#66) - fix fcntl usage when set socket nonblock (#69) - minor fix (#61) - add condition log macro (#77) - Define and use notWaitForRetryTimeout (#82) - upgrade travis to gcc 7 (#91) - add func errCodeToString (#79) - Introduce a reconnect mechanism in waitPoll (#88)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @everpcpc