Skip to content

API test fix #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-yao merged 4 commits into from
Mar 20, 2024
Merged

API test fix #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04a142d
API test fix
tim-yao Mar 19, 2024
00a5269
Fix the API report issue
tim-yao Mar 20, 2024
e7b5334
Update notify_slack.yml
tim-yao Mar 20, 2024
20b5c37
Fix the slack api error
tim-yao Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
cd /app
if [ -e tests/newman/tide.collection.json ]
then
if [[ ${TEST_NEWMAN_DISABLE_CORE} == true ]]
if [[ "${TEST_NEWMAN_DISABLE_CORE}" == "true" ]]
Copy link
Contributor Author

@tim-yao tim-yao Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixed the sh: true: unknown operand error in GHA API job step

then
echo "==> Core Tests are disabled by env var TEST_NEWMAN_DISABLE_CORE. Skip the test."
else
Expand Down
15 changes: 11 additions & 4 deletions .github/workflows/notify_slack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,16 @@ jobs:
else
echo TEST_ENVIRONMENTS="*BE URL:* $BE_BASE_URL \n *FE URL:* $FE_BASE_URL" >> $GITHUB_ENV
fi
env:
BE_BASE_URL: ${{ inputs.be_url }}
FE_BASE_URL: ${{ inputs.fe_url }}
- name: prepare-report-api
if: ${{ inputs.test_type == ':postman:' }}
run: |
echo "REPORT_TEXT=API test report is stored in the CI job summary artifacts" >> $GITHUB_ENV
Comment on lines +66 to +69
Copy link
Contributor Author

@tim-yao tim-yao Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API test doesn't have a report stored in the cloud so no report URL can be sent to Slack, added a specific message for it.

- name: prepare-report-e2e
if: ${{ inputs.test_type != ':postman:' }}
run: |
if [ -f "report-url.txt" -a -s "report-url.txt" ]; then
echo "Workflow status is $WORKFLOW_CONCLUSION"
if [ "$WORKFLOW_CONCLUSION" = "success" ]; then
Expand All @@ -70,9 +80,6 @@ jobs:
else
echo "REPORT_TEXT=:crying_cat_face: No report found. Testing may have been skipped." >> $GITHUB_ENV
fi
env:
BE_BASE_URL: ${{ inputs.be_url }}
FE_BASE_URL: ${{ inputs.fe_url }}
- name: sdp-test-report-success
uses: slackapi/slack-github-action@v1.24.0
if: env.WORKFLOW_CONCLUSION == 'success'
Expand Down Expand Up @@ -158,4 +165,4 @@ jobs:
LINK: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
BRANCH_LINK: ${{ github.event.pull_request && github.head_ref || github.ref_name }}
SLACK_BOT_TOKEN: ${{ secrets.TEST_SLACK_BOT_TOKEN }}
ARTIFACTS_URL: "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
ARTIFACTS_URL: "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"