Skip to content

[SD-324] Mutliple ID fix #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klaukl merged 3 commits into from
Nov 10, 2024
Merged

[SD-324] Mutliple ID fix #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2efb5d1
only take 1st match
klaukl Nov 9, 2024
28c928a
removed response body echo
klaukl Nov 9, 2024
1a40a73
clean
klaukl Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/post_jira_comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,11 @@ jobs:
# Handle the API response
if [ "$http_code" -eq 201 ]; then
echo "Comment posted successfully to Jira issue ${{ inputs.jira_id }}"
echo "Response Body: $response_body"
else
echo "Failed to post comment to Jira issue ${{ inputs.jira_id }}. HTTP Code: $http_code"
echo "Response Body: $response_body"

echo '### ⚠️ Failed to post comment to Jira' >> $GITHUB_STEP_SUMMARY
echo "#### Issue ID: ${{ inputs.jira_id }}" >> $GITHUB_STEP_SUMMARY
echo "#### HTTP Code: $http_code" >> $GITHUB_STEP_SUMMARY
echo "#### Response Body: $response_body" >> $GITHUB_STEP_SUMMARY

fi
4 changes: 2 additions & 2 deletions .github/workflows/test_post_jira.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ jobs:
commit_message=$(echo "$commit_info" | jq -r '.commit.message')

# Extract JIRA ID
JIRA_ID=$(echo "$commit_message" | grep -oE 'SCFA-[0-9]{1,5}' || true) # Prevents non-zero exit code
JIRA_ID=$(echo "$commit_message" | grep -oE 'SCFA-[0-9]{1,5}' | head -n 1 || true)
Copy link
Contributor

@GROwen GROwen Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @klaukl , I'm looking into an alternative using awk to make this more generic.


# Check if JIRA ID is found
if [ -z "$JIRA_ID" ]; then
echo "No JIRA ID found in commit message: $commit_message"
Expand Down