Place column comments at the end of the line#199
Merged
Conversation
…olumn-comments-at-the-end-of-the-line
Contributor
Author
|
Either the lint rules changed, or what was merged into this branch is not properly formatted. I will fix this this week. |
Contributor
Author
|
@drwl : The checks seem fine again. |
Contributor
Author
|
@drwl : Seems you need to approve the PR again for the CI workflows to be started 🤔 If I understand what I read from GitHub properly. |
Contributor
Author
|
@drwl : Thanks for the maintenance on this. 👌🏼 Did not have time to tackle it in the last few weeks (the lint issues). |
drwl
approved these changes
Jul 1, 2025
Owner
drwl
left a comment
drwl
left a comment
There was a problem hiding this comment.
Thanks for taking the time and adding this as well as updating the test coverage!
Adeynack
deleted the
feature/164-place-column-comments-at-the-end-of-the-line
branch
Owner
|
I just release v4.17.0 and it contains this change. Let me know if there are any issues. |
drwl
pushed a commit
that referenced
this pull request
Sep 20, 2025
…ion_of_column_comment option (#263) This is a follow-up to the changes added in #199. We noticed that when using the `rightmost` option for column comment position, any multi-line column comments were not being escaped in the same manner as the `with_name` option. This causes problems with generated model annotation as invalid uncommented newlines then appear. For example: **Before** ``` # notes :text(55) not null Notes. May include things like notes. ``` **After** ``` # notes :text(55) not null Notes\nMay include things like notes. ``` I have also updated the documentation for this option to include the available values – I had to dig through the codebase to find the possible values for the `--position-of-column-comments` option. Thanks for this great gem, my company uses it in our projects 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164
Adds the configuration
position_of_column_comment, now defaults towith_name(already existing behavior), and can also be set torightmost_column.There was a bit of moving code around involved, as some information about other attribute was needed (e.g.: the
attributesof other columns, to determine how wide this column must be).The only formats where it got implemented though are:
The other formats I do not know well, and would ask anyone with better knowledge of them to work on it.