Conversation
…ion_of_column_comment option This follows the method used for the "with_name" value. Test coverage newlines in comments has been added for markdown formatting as well.
drwl
approved these changes
Sep 20, 2025
Owner
drwl
left a comment
There was a problem hiding this comment.
Thanks for the bug fix and the kind note. Also thank you for improving test coverage 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the changes added in #199.
We noticed that when using the
rightmostoption for column comment position, any multi-line column comments were not being escaped in the same manner as thewith_nameoption. This causes problems with generated model annotation as invalid uncommented newlines then appear. For example:Before
After
I have also updated the documentation for this option to include the available values – I had to dig through the codebase to find the possible values for the
--position-of-column-commentsoption.Thanks for this great gem, my company uses it in our projects 👏