WIP: add hash witness merkle root in block header

[scravy]

• Hey, not too rough
• Hurt me plenty
• Ultra-Violence

Separate PRs

• introduce ReducedTestingSetup for blockchain agnostic unit tests #89 introduce ReducedTestingSetup for blockchain agnostic unit tests

Unit Tests

• arith_uint256_tests*
  • basics*
  • shifts*
  • unaryOperators*
  • bitwiseOperators*
  • comparison*
  • plusMinus*
  • multiply*
  • divide*
  • methods*
  • bignum_SetCompact*
  • getmaxcoverage*
• addrman_tests*
  • addrman_simple*
  • addrman_ports*
  • addrman_select*
  • addrman_new_collisions*
  • addrman_tried_collisions*
  • addrman_find*
  • addrman_create*
  • addrman_delete*
  • addrman_getaddr*
  • caddrinfo_get_tried_bucket*
  • caddrinfo_get_new_bucket*
• amount_tests*
  • MoneyRangeTest*
  • GetFeeTest*
  • BinaryOperatorTest*
  • ToStringTest*
• allocator_tests*
  • arena_tests*
  • lockedpool_tests_mock*
  • lockedpool_tests_live*
• base16_tests*
  • encode_base16*
  • decode_base16*
  • decode_base16_fail*
• base32_tests*
  • base32_testvectors*
• base58_tests*
  • base58_EncodeBase58*
  • base58_DecodeBase58*
  • base58_keys_valid_parse*
  • base58_keys_valid_gen*
  • base58_keys_invalid*
• base64_tests*
  • base64_testvectors*
• bech32_tests*
  • bip173_testvectors_valid*
  • bip173_testvectors_invalid*
• bip32_tests*
  • bip32_test1*
  • bip32_test2*
  • bip32_test3*
• blockchain_difficulty_tests*
  • get_difficulty_for_very_low_target*
  • get_difficulty_for_low_target*
  • get_difficulty_for_mid_target*
  • get_difficulty_for_high_target*
  • get_difficulty_for_very_high_target*
  • get_difficulty_for_null_tip*
  • get_difficulty_for_null_block_index*
  • get_difficulty_for_block_index_overrides_tip*
• blockencodings_tests*
  • SimpleRoundTripTest*
  • NonCoinbasePreforwardRTTest*
  • SufficientPreforwardRTTest*
  • EmptyBlockRoundTripTest*
  • TransactionsRequestSerializationTest*
• bloom_tests*
  • bloom_create_insert_serialize*
  • bloom_create_insert_serialize_with_tweak*
  • bloom_create_insert_key*
  • bloom_match*
  • merkle_block_1*
  • merkle_block_2*
  • merkle_block_2_with_update_none*
  • merkle_block_3_and_serialize*
  • merkle_block_4*
  • merkle_block_4_test_p2pubkey_only*
  • merkle_block_4_test_update_none*
  • rolling_bloom*
• bswap_tests*
  • bswap_tests*
• checkqueue_tests*
  • test_CheckQueue_Correct_Zero*
  • test_CheckQueue_Correct_One*
  • test_CheckQueue_Correct_Max*
  • test_CheckQueue_Correct_Random*
  • test_CheckQueue_Catches_Failure*
  • test_CheckQueue_Recovers_From_Failure*
  • test_CheckQueue_UniqueCheck*
  • test_CheckQueue_Memory*
  • test_CheckQueue_FrozenCleanup*
  • test_CheckQueueControl_Locks*
• coins_tests*
  • coins_cache_simulation_test*
  • updatecoins_simulation_test*
  • ccoins_serialization*
  • ccoins_access*
  • ccoins_spend*
  • ccoins_add*
  • ccoins_write*
• compress_tests*
  • compress_amounts*
• semaphore_tests*
  • barrier_example*
• crypto_tests*
  • ripemd160_testvectors*
  • sha1_testvectors*
  • sha256_testvectors*
  • sha512_testvectors*
  • hmac_sha256_testvectors*
  • hmac_sha512_testvectors*
  • aes_testvectors*
  • aes_cbc_testvectors*
  • chacha20_testvector*
  • countbits_tests*
• cuckoocache_tests*
  • test_cuckoocache_no_fakes*
  • cuckoocache_hit_rate_ok*
  • cuckoocache_erase_ok*
  • cuckoocache_erase_parallel_ok*
  • cuckoocache_generations*
• DoS_tests*
  • outbound_slow_chain_eviction*
  • stale_tip_peer_management*
  • DoS_banning*
  • DoS_banscore*
  • DoS_bantime*
  • DoS_mapOrphans*
• finalizationstate_tests*
  • constructor*
  • initialize_epcoh_wrong_height_passed*
  • initialize_epcoh_insta_finalize*
  • initialize_epoch_reward_factor*
  • validate_deposit_tx_not_enough_deposit*
  • validate_deposit_tx_double_deposit*
  • process_deposit_tx*
  • validate_vote_tx_no_deposit*
  • validate_vote_tx_non_votable_already_voted*
  • validate_vote_tx_non_votable_wrong_target_epoch*
  • validate_vote_tx_non_votable_wrong_target_hash*
  • validate_vote_tx_non_votable_source_epoch_not_justified*
  • process_vote_tx_success*
  • process_vote_tx_success_with_reward_no_consensus*
  • process_vote_tx_success_with_finalization*
  • validate_logout_not_a_validator*
  • validate_logout_before_start_dynasty*
  • validate_logout_already_logged_out*
  • process_logout_end_dynasty*
  • validate_withdraw_not_a_validator*
  • process_withdraw_before_end_dynasty*
  • process_withdraw_too_early*
  • process_withdraw_completely_slashed*
  • is_slashable_not_a_validator*
  • is_slashable_not_the_same_validator*
  • is_slashable_too_early*
  • is_slashable_same_vote*
  • is_slashable_already_slashed*
  • process_slash_duplicate_vote*
  • process_slash_surrounding_vote*
  • getrecommendedvote*
  • map_empty_initializer*
• finalization_params_tests*
  • parse_params_invalid_json*
  • parse_params_param_not_a_number_fallback_default*
  • parse_params_negative_unsigned_params*
  • parse_params_values*
• getarg_tests*
  • boolarg*
  • stringarg*
  • intarg*
  • doubledash*
  • boolargno*
• hash_tests*
  • murmurhash3*
  • siphash*
• interpreter_tests*
  • signaturehash_vote*
• key_tests*
  • key_test1*
• limitedmap_tests*
  • limitedmap_test*
• dbwrapper_tests*
  • dbwrapper*
  • dbwrapper_batch*
  • dbwrapper_iterator*
  • existing_data_no_obfuscate*
  • existing_data_reindex*
  • iterator_ordering*
  • iterator_string_ordering*
• main_tests*
  • block_subsidy_test*
  • subsidy_limit_test*
  • test_combiner_all*
• mempool_tests*
  • MempoolRemoveTest*
  • MempoolIndexingTest*
  • MempoolAncestorIndexingTest*
  • MempoolSizeLimitTest*
• merkle_tests*
  • merkle_test*
• merkleblock_tests*
  • merkleblock_construct_from_txids_found*
  • merkleblock_construct_from_txids_not_found*
• miner_tests*
  • CreateNewBlock_validity*
• multisig_tests*
  • multisig_verify*
  • multisig_IsStandard*
  • multisig_Sign*
• net_tests*
  • cnode_listen_port*
  • caddrdb_read*
  • caddrdb_read_corrupted*
  • cnode_simple_test*
• netbase_tests*
  • netbase_networks*
  • netbase_properties*
  • netbase_splithost*
  • netbase_lookupnumeric*
  • onioncat_test*
  • subnet_test*
  • netbase_getgroup*
• pmt_tests*
  • pmt_test1*
  • pmt_malleability*
• policyestimator_tests*
  • BlockPolicyEstimates*
• pow_tests*
  • get_next_work*
  • get_next_work_pow_limit*
  • get_next_work_lower_limit_actual*
  • get_next_work_upper_limit_actual*
  • GetBlockProofEquivalentTime_test*
• PrevectorTests*
  • PrevectorTestInt*
• raii_event_tests*
  • raii_event_creation*
  • raii_event_order*
• random_tests*
  • osrandom_tests*
  • fastrandom_tests*
  • fastrandom_randbits*
• reverselock_tests*
  • reverselock_basics*
  • reverselock_errors*
• rpc_tests*
  • rpc_rawparams*
  • rpc_togglenetwork*
  • rpc_rawsign*
  • rpc_createraw_op_return*
  • rpc_format_monetary_values*
  • rpc_parse_monetary_values*
  • json_parse_errors*
  • rpc_ban*
  • rpc_convert_values_generatetoaddress*
• sanity_tests*
  • basic_sanity*
• scheduler_tests*
  • manythreads*
• script_P2SH_tests*
  • sign*
  • norecurse*
  • set*
  • is*
  • switchover*
  • AreInputsStandard*
• script_tests*
  • script_build*
  • script_json_test*
  • script_PushData*
  • script_CHECKMULTISIG12*
  • script_CHECKMULTISIG23*
  • script_combineSigs*
  • script_standard_push*
  • script_IsPushOnly_on_invalid_scripts*
  • script_GetScriptAsm*
  • script_FindAndDelete*
  • script_HasValidOps*
  • script_can_append_self*
  • encode_decode_vote_data*
  • extract_vote_data_from_scriptsig*
  • extract_vote_data_from_witness*
• script_standard_tests*
  • script_standard_Solver_success*
  • script_standard_Solver_failure*
  • script_standard_ExtractDestination*
  • script_standard_ExtractDestinations*
  • script_standard_GetScriptFor_*
  • script_standard_IsMine*
• scriptnum_tests*
  • creation*
  • operators*
• serialize_tests*
  • sizes*
  • floats_conversion*
  • doubles_conversion*
  • floats*
  • doubles*
  • varints*
  • varints_bitpatterns*
  • compactsize*
  • noncanonical*
  • insert_delete*
  • class_methods*
• sighash_tests*
  • sighash_test*
  • sighash_from_data*
• sigopcount_tests*
  • GetSigOpCount*
  • GetTxSigOpCost*
• sign_tests*
  • producesignature_vote_witness*
• skiplist_tests*
  • skiplist_test*
  • getlocator_test*
  • findearliestatleast_test*
  • findearliestatleast_edge_test*
• streams_tests*
  • streams_vector_writer*
  • streams_serializedata_xor*
• timedata_tests*
  • util_MedianFilter*
• torcontrol_tests*
  • util_SplitTorReplyLine*
  • util_ParseTorReplyMapping*
• transaction_tests*
  • tx_valid*
  • tx_invalid*
  • basic_transaction_tests*
  • test_Get*
  • test_big_witness_transaction*
  • test_witness*
  • test_IsStandard*
  • mutabletransaction_set_type_mulitple_times*
• txvalidation_tests*
  • tx_mempool_reject_coinbase*
• tx_validationcache_tests*
  • tx_mempool_block_doublespend*
  • checkinputs_test*
• uint256_tests*
  • basics*
  • comparison*
  • methods*
  • conversion*
• util_tests*
  • util_criticalsection*
  • util_ParseHex*
  • util_HexStr*
  • util_DateTimeStrFormat*
  • util_ParseParameters*
  • util_GetArg*
  • util_FormatMoney*
  • util_ParseMoney*
  • util_IsHex*
  • util_IsHexNumber*
  • util_seed_insecure_rand*
  • util_TimingResistantEqual*
  • strprintf_numbers*
  • gettime*
  • test_ParseInt32*
  • test_ParseInt64*
  • test_ParseUInt32*
  • test_ParseUInt64*
  • test_ParseDouble*
  • test_FormatParagraph*
  • test_FormatSubVersion*
  • test_ParseFixedPoint*
  • test_LockDirectory*
• util_fun_tests*
  • take_while_int_vector*
  • take_while_char_vector*
  • take_while_string*
  • drop_while_int_vector_fun_ptr*
  • drop_while_int_vector_lambda*
  • drop_while_int_vector*
  • drop_while_char_vector*
  • drop_while_string*
  • filter_int_vector*
  • filter_not_int_vector*
  • zip_with_int_vector*
  • zip_with_different_lengths*
  • fold_left_test*
  • fold_right_test*
  • scan_left_test*
• validation_block_tests*
  • processnewblock_signals_ordering*
• versionbits_tests*
  • versionbits_test*
  • versionbits_computeblockversion*
• waiter_tests*
  • wait_and_wake_test*
• mnemonic_tests*
  • mnemonic_test*
  • mnemonic_test_fails*
  • mnemonic_addchecksum*
  • mnemonic_detect_english*
  • mnemonic_detect_french*
  • mnemonic_detect_italian*
  • mnemonic_detect_spanish*
  • mnemonic_detect_japanese*
  • mnemonic_detect_korean*
  • mnemonic_detect_chinese_simplified*
  • mnemonic_detect_chinese_traditional*
  • mnemonic_seed_english*
  • mnemonic_seed_english_with_passphrase*
  • mnemonic_seed_spanish*
  • mnemonic_seed_spanish_with_passphrase*
  • mnemonic_test_json*
• proposer_tests*
  • start_stop*
  • stop_twice*
  • stop_without_start*
  • stop_twice_without_start*
  • wallet_distribution*
  • single_wallet_too_many_threads_specified*
  • single_wallet_too_few_threads_specified*
• accounting_tests*
  • acc_orderupgrade*
• wallet_tests*
  • coin_selection_tests*
  • ApproximateBestSubset*
  • rescan*
  • importwallet_rescan*
  • coin_mark_dirty_immature_credit*
  • ComputeTimeSmart*
  • LoadReceiveRequests*
  • ListCoins*
• wallet_crypto*
  • passphrase*
  • encrypt*
  • decrypt*

[scravy]

current unit test state:

$ for category in $(src/test/test_unite --list_content 2>&1 | grep -v -F '    '); do \
> src/test/test_unite --run_test=${category} > /dev/null 2>&1 && echo ${category} passed || echo ${category} failed; \
> done
arith_uint256_tests* passed
addrman_tests* passed
amount_tests* passed
allocator_tests* passed
base16_tests* passed
base32_tests* passed
base58_tests* failed
base64_tests* passed
bech32_tests* passed
bip32_tests* failed
blockchain_difficulty_tests* passed
blockencodings_tests* failed
bloom_tests* failed
bswap_tests* passed
checkqueue_tests* failed
coins_tests* passed
compress_tests* passed
semaphore_tests* passed
crypto_tests* passed
cuckoocache_tests* passed
DoS_tests* failed
finalizationstate_tests* passed
finalization_params_tests* passed
getarg_tests* passed
hash_tests* passed
interpreter_tests* passed
key_tests* failed
limitedmap_tests* passed
dbwrapper_tests* passed
main_tests* failed
mempool_tests* failed
merkle_tests* failed
merkleblock_tests* failed
miner_tests* failed
multisig_tests* passed
net_tests* failed
netbase_tests* passed
pmt_tests* passed
policyestimator_tests* passed
pow_tests* failed
PrevectorTests* failed
raii_event_tests* passed
random_tests* passed
reverselock_tests* passed
rpc_tests* failed
sanity_tests* passed
scheduler_tests* passed
script_P2SH_tests* passed
script_tests* passed
script_standard_tests* passed
scriptnum_tests* passed
serialize_tests* passed
sighash_tests* passed
sigopcount_tests* passed
sign_tests* passed
skiplist_tests* passed
streams_tests* passed
timedata_tests* passed
torcontrol_tests* passed
transaction_tests* passed
txvalidation_tests* failed
tx_validationcache_tests* failed
uint256_tests* passed
util_tests* passed
util_fun_tests* passed
validation_block_tests* failed
versionbits_tests* failed
waiter_tests* passed
mnemonic_tests* failed
proposer_tests* passed
accounting_tests* failed
wallet_tests* failed
wallet_crypto* passed