Fix a typo: __KERNEL -> __KERNEL__

[msabramo]

-# else /* !__KERNEL */
+# else /* !__KERNEL__ */

[dtrace4linux]

Super - thanks Marc. Merged.

On 28 February 2012 21:20, Marc Abramowitz
reply@reply.github.com
wrote:

You can merge this Pull Request by running:

 git pull https://github.com/msabramo/linux misc_tweaks

Or you can view, comment on it, or merge it online at:

 #1

-- Commit Summary --

• Fix a typo: KERNEL -> __KERNEL

-- File Changes --

M linux/linux_types.h (2)

-- Patch Links --

 https://github.com/dtrace4linux/linux/pull/1.patch
 https://github.com/dtrace4linux/linux/pull/1.diff

---

Reply to this email directly or view it on GitHub:
#1

[dtrace4linux]

Am confused by your other mail. I compile fine on Ubuntu 11.10 - your
first error is:

In file included from ../linux/sys/types.h:4:0,
from ctf_lib.c:29:
.../linux/linux_types.h:146:38: fatal error: /usr/include/sys/types.h: No
such file or directory

which implies you dont have the gcc dev kit installed. My get-deps.pl
is probably more for 64bit kernel,
so you may want to validate what you have or are missing.

Ubuntu tends to be my primary dev platform, so it should just work,
assuming the dependencies are
there (I am getting better at tracking what I install on my system,
but am not perfect yet).

tx

On 28 February 2012 21:56, Paul Fox paul.d.fox@gmail.com wrote:

Super - thanks Marc. Merged.

On 28 February 2012 21:20, Marc Abramowitz
reply@reply.github.com
wrote:

You can merge this Pull Request by running:

 git pull https://github.com/msabramo/linux misc_tweaks

Or you can view, comment on it, or merge it online at:

 #1

-- Commit Summary --

• Fix a typo: KERNEL -> __KERNEL

-- File Changes --

M linux/linux_types.h (2)

-- Patch Links --

 https://github.com/dtrace4linux/linux/pull/1.patch
 https://github.com/dtrace4linux/linux/pull/1.diff

---

Reply to this email directly or view it on GitHub:
#1

[msabramo]

marca@ubuntu:~/src/dtrace4linux/dtrace-20120225$ cat /etc/debian_version 
wheezy/sid
marca@ubuntu:~/src/dtrace4linux/dtrace-20120225$ uname -a
Linux ubuntu 3.0.0-14-generic #23-Ubuntu SMP Mon Nov 21 20:34:47 UTC 2011 i686 i686 i386 GNU/Linux

Here's what seemed to do the trick for me to get me /usr/include/sys/types.h:

$ sudo apt-get install libc6-dev-amd64

(kind of weird since uname says that my arch is i686; not amd64 -- but maybe that's just a naming thing). I already had libc6-dev and build-essential and even tried reinstalling it and that didn't help. Installing libc6-dev-amd64 seems to be necessary.

With that I got:

...
cd cmd/ctfconvert ; make --no-print-directory
=================================================================
=== You need /usr/lib/libdwarf.a and /usr/lib/libbfd.a installed to build.
=== 
=== apt-get install binutils-dev
=== apt-get install libdw-dev
=== 
=== Without these, we will not build ctfconvert (needed for 
=== SDT structure definitions).
=================================================================
...
  Building modules, stage 2.
  MODPOST 1 modules
  CC      /home/marca/src/dtrace4linux/dtrace-20120225/build-3.0.0-14-generic/driver/dtracedrv.mod.o
  LD [M]  /home/marca/src/dtrace4linux/dtrace-20120225/build-3.0.0-14-generic/driver/dtracedrv.ko
tools/mkctf.sh
build/ctfconvert not available - so not building the linux.ctf file
NOTE: The build is complete, but build/ctfconvert is not available.
      This means you will get run time errors from the io.d and sched.d files
      due to undefined kernel structure definitions. Simply delete or rename
      these files until a fix can be put in place to handle older
      distros which do not have the required libdwarf dependencies.

      (Typical error is references to undefined struct definitions such
      as dtrace_cpu_t).

sync

I tried installing libdw-dev as the message suggested, but that did not help as libdw-dev does not provide libdwarf.a. Instead, I installed libdwarf-dev and that seemed to do the trick so that it could build ctfconvert.

So here's the whole list of packages that I recommend for Ubuntu users:

sudo apt-get install build-essential flex libelf-dev libc6-dev-amd64 binutils-dev libdwarf-dev

Thank you so much for doing this work to port DTrace to Linux!!!