Feature/parallel embeddings#569
Conversation
|
Tests require this recently integrated bugfix: dwavesystems/minorminer@e40339a, I haven't modified the requirements accordingly. |
|
Add Gunnar Millar @gunnarmillar to our team. I'd like him to take a stab at this. Other reviewers welcome. I'd like this functionality to be available for the AQC workshop June 13th (ideally the final practice May 26th). |
|
@JoelPasvolsky This code is already used in the first draft of the AQC workshop repo. |
| @@ -0,0 +1,520 @@ | |||
| # Copyright 2018 D-Wave Systems Inc. | |||
There was a problem hiding this comment.
| # Copyright 2018 D-Wave Systems Inc. | |
| # Copyright 2025 D-Wave |
| If embeddings and source graph nodes are inconsistent. | ||
| If embeddings and target graph nodes are inconsistent. | ||
|
|
||
| Examples: |
There was a problem hiding this comment.
Examples were edited in the wrong place. See the sample() Examples, which will be moved here next commit.
randomir
left a comment
There was a problem hiding this comment.
The code looks really good. I did a thorough pass over the code and docs. Tomorrow I'll go over the tests.
To fix the CI, you should update minorminer in requirements.txt to 0.2.18 (version with parallel embeddings).
Co-authored-by: Radomir Stevanovic <radomir.stevanovic@gmail.com>
6999b06 to
d2d2d75
Compare
|
@jackraymond, the PR is rebased and cleaned-up. I reviewed the tests, they LGTM, except the three that are failing (check the CI output). Once you fix those tests, we can merge and release. |
The failing tests are because it relies on code in the most recent master of minorminer, but missing from minorminer 0.2.18 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #569 +/- ##
==========================================
- Coverage 88.91% 86.87% -2.05%
==========================================
Files 21 22 +1
Lines 1904 1988 +84
==========================================
+ Hits 1693 1727 +34
- Misses 211 261 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
A composite for parallelizing job submissions across structured samplers (i.e. the QPU)
Using minorminer sublattice mappings, this composite should allow us to mark the TilingComposite as deprecated, tiling is a special case of the functionality supported (see examples and tests - all tests passed by TilingComposite are emulated in the new code)
Closes several open issues including tiling support for Zephyr (Adv2) :
#456
#180
#213
It provides an enhanced solution to some other closed cases, like support for advantage: #213