Parallel embeddings modification to accommodate composite failure to propagate graph type information#266
Merged
randomir merged 4 commits intodwavesystems:mainfrom Jun 5, 2025
Conversation
jackraymond
changed the title
randomir
reviewed
Jun 4, 2025
| embedder=embedder, | ||
| embedder_kwargs=embedder_kwargs, | ||
| ) | ||
| if T.graph.get("family", T_family) not in {"chimera", "pegasus", "zephyr"}: |
Member
There was a problem hiding this comment.
Since T is optional, should check for None first.
randomir
reviewed
Jun 4, 2025
Co-authored-by: Radomir Stevanovic <radomir.stevanovic@gmail.com>
Merged
mahdiehmalekian
pushed a commit
to mahdiehmalekian/minorminer
that referenced
this pull request
Nov 14, 2025
### New Features - Allow lattice type and lattice dimensions to be passed as options for `find_sublattice_embeddings()`. See [\dwavesystems#266](dwavesystems#266). ### Bug Fixes - Fix `find_sublattice_embeddings()` to not produce non-disjoint embeddings when `use_tile_embedding=True` is set. See [\dwavesystems#265](dwavesystems#265).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow lattice type and lattice dimensions to be passed as options for find_sublattice_embeddings.
The embedder might be used by methods in which the graph family cannot be guaranteed,
e.g.
dwavesystems/dwave-system#569
If we apply the ParallelEmbeddingComposite to a composite of the QPU, rather than directly, topology information is deleted. We can still use ParallelEmbeddingComposite as a tiling composite if we allow explicit passing of this information