Bugfix: non-disjoint embeddings allowed by . Documentation refinements#265
Merged
randomir merged 3 commits intodwavesystems:mainfrom Apr 30, 2025
Merged
Bugfix: non-disjoint embeddings allowed by . Documentation refinements#265randomir merged 3 commits intodwavesystems:mainfrom
randomir merged 3 commits intodwavesystems:mainfrom
Conversation
…anch with testing derived from TilingComposite
Contributor
Author
|
Bugfixes and documentation are with a view to replacing the TilingComposite: https://github.com/jackraymond/dwave-system/tree/feature/parallel_embeddings |
randomir
reviewed
Apr 28, 2025
Merged
mahdiehmalekian
pushed a commit
to mahdiehmalekian/minorminer
that referenced
this pull request
Nov 14, 2025
### New Features - Allow lattice type and lattice dimensions to be passed as options for `find_sublattice_embeddings()`. See [\dwavesystems#266](dwavesystems#266). ### Bug Fixes - Fix `find_sublattice_embeddings()` to not produce non-disjoint embeddings when `use_tile_embedding=True` is set. See [\dwavesystems#265](dwavesystems#265).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The significant change in this pull request is the bugfix at line 533 (new version), previous this allowed non-disjoint embeddings to be produced in typical use cases of the use_tile_embedding=True option (inviable for parallelization). The changes is tested.
Other changes relate to simplification of the documentation to more clearly reflect the defaulting process for parameters and permitted values for arguments.