Conversation
bhelx
reviewed
Nov 11, 2024
| <% } -%> | ||
| <% if (!p.nullable) {%> | ||
| <%- p.name %>: <%- toPythonType(p) %> | ||
| <% } %> |
Contributor
There was a problem hiding this comment.
If the only difference b/w these two loops is the nullable part. maybe we can merge them something like this?
@dataclass
class <%- capitalize(schema.name) %>(extism.Json):
<% schema.properties.forEach(p => { -%>
<% if (p.description) { -%>
# <%- formatCommentBlock(p.description, "# ") %>
<% } -%>
<% if (p.nullable) {%>
<%- p.name %>: <%- toPythonType(p) %> = None
<% } else { %>
<%- p.name %>: <%- toPythonType(p) %>
<% } %>
<% }) %>
<% } %>
<% }); %>
or just customize the = None part
Author
There was a problem hiding this comment.
It's an ordering issue, the fields with default values have to come after the fields with no defaults.
bhelx
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10
Currently when constructing a type with nullable fields the user is required to explicitly pass
Noneif no argument is needed.This sets
nullablefields toNoneby default - to do this we need to list all non-nullable fields first, then the nullable ones because Python requires arguments with default values to be listed last. This means the order of arguments for type constructors might be in a different order from the schema and other PDKs, but I'm not sure there is another way around this.