Conversation
bhelx
commented
Oct 23, 2024
|
|
||
| if (!tp) throw new Error("Cant convert property to Python type: " + property.type) | ||
| if (!property.nullable) return tp | ||
| if (!property.nullable && !property.required) return tp |
Contributor
Author
There was a problem hiding this comment.
Trying to decide what the logic should be here and if extism.Json is able to distinguish b/w null and optional.
Contributor
Author
There was a problem hiding this comment.
@zshipko is there an equivalent of omitempty for the json encoder? We may want to skip the key if the value is None and the type is !required
There was a problem hiding this comment.
not really, I think the best way to handle nullable is to make the field Optional[T] and for non-required we can do the same, but a default value for that field in the dataclass.
I haven't totally thought it through but that should work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.