Skip to content

Support nullable vs required #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhelx merged 1 commit into from
Nov 11, 2024
Merged

Support nullable vs required #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"typescript": "^5.3.2"
},
"dependencies": {
"@dylibso/xtp-bindgen": "1.0.0-rc.8",
"@dylibso/xtp-bindgen": "1.0.0-rc.11",
"ejs": "^3.1.10"
}
}
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function toPythonType(property: Property): string {
}

if (!tp) throw new Error("Cant convert property to Python type: " + property.type)
if (!property.nullable) return tp
if (!property.nullable && !property.required) return tp
Copy link
Contributor Author

@bhelx bhelx Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to decide what the logic should be here and if extism.Json is able to distinguish b/w null and optional.

Copy link
Contributor Author

@bhelx bhelx Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zshipko is there an equivalent of omitempty for the json encoder? We may want to skip the key if the value is None and the type is !required

Copy link

@zshipko zshipko Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, I think the best way to handle nullable is to make the field Optional[T] and for non-required we can do the same, but a default value for that field in the dataclass.

I haven't totally thought it through but that should work.

return `Optional[${tp}]`
}

Expand Down