only include constraint in payload when explicitly set#198
Closed
edx4900 wants to merge 1 commit intodynotx:mainfrom
Closed
only include constraint in payload when explicitly set#198edx4900 wants to merge 1 commit intodynotx:mainfrom
edx4900 wants to merge 1 commit intodynotx:mainfrom
Conversation
Collaborator
|
Hey! Good catch. I went ahead and made a separate branch with my implementation of the fix, which fixes the root of issue. Let me know if this makes sense and how it looks to you and we can merge it in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When
UpdateEntitySchemawas called to update only non-constraint properties, this would resend the existing constraint. Benchling interpreted this as attempting to add an additional constraint and would reject it as a duplicate add.Fix
This fix excludes the constraint from the update payload when
constraint_fieldsisn't part of the requested changes