Merged
Conversation
nirmit-damania-dyno
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PR #198...
In Benchling's API, the expected payload for updating entity schema properties is just the changed properties. However, Liminal was sending the full schema properties as the payload with the changed property as part of it. This resulted in the bug mentioned in PR #198 where Benchling interpreted a constraint getting passed in as attempting to add an additional constraint, rejecting it as a duplicate add.
Rather than just dropping constraints, I chose to follow the Benchling API expectations, and modified the
update_schema_propsfunction to generate theUpdateTagSchemaModelwith only the changed properties.Tested locally by updating schema properties when constraints are already set