refactor and fix multiple issues #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is a lot. And the dependency stuff is still not as clean as I would like. I need to get the test stuff I have written committed too. Just need to get these merged though so I can stop thinking about them. |
Member
|
Confirmed that this fixes the string literal patching issue for me, i.e.: |
- Fixup debug messages - Remove dead code - No more DEPENDENCY state - Reachability test is now the "Inclusion tree" for determining which syms/sections will be included in the output - 'reachable' field is now and 'include' and is the sole consideration in including sections/symbols (no more complex conditional checks) - Order LOCAL before GLOBAL in the symbol table. Apparently, after a FILE sym, all LOCAL symbols should precede GLOBAL syms or readelf shows <corrupt> - Handle __ksymtab_strings section and __ksymtab_* syms Signed-off-by: Seth Jennings <sjenning@redhat.com>
Member
|
@Spartacus06 Frankly this looks awesome. I bow before you sir. Nice work! And it fixes the aforementioned string literal issue, as well as #40. |
jpoimboe
added a commit
that referenced
this pull request
Mar 5, 2014
refactor and fix multiple issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.