This repository was archived by the owner on May 30, 2025. It is now read-only.
feat(EbayAvatar): add new component #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenriqueLimas
requested review from
ArtBlue,
LuLaValva,
aaron-nance,
agliga and
darkwebdev
🦋 Changeset detectedLatest commit: fa536a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* 308: Add skeleton loading component * fix eslint * Add support for 'as' for components and 'color' - add changeset * Add readme content * Remove default aria-label --------- Co-authored-by: HenriqueLimas <henrique.ramos.limas@gmail.com>
darkwebdev
approved these changes
Feb 11, 2025
agliga
approved these changes
Feb 11, 2025
agliga
left a comment
agliga
left a comment
There was a problem hiding this comment.
Just note there is going to be a couple of minor changes in avatar this next skin version
Pr here eBay/skin#2565
Member
Author
|
@agliga, I will update the avatar after we merge the Skin PR |
HenriqueLimas
added a commit
that referenced
this pull request
Feb 25, 2025
* feat: Add skeleton loading component (#378) * 308: Add skeleton loading component * fix eslint * Add support for 'as' for components and 'color' - add changeset * Add readme content * Remove default aria-label --------- Co-authored-by: HenriqueLimas <henrique.ramos.limas@gmail.com> * feat(EbayAvatar): add new component --------- Co-authored-by: Aaron Nance <anance@ebay.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same component as Marko version https://github.com/eBay/ebayui-core/tree/master/src/components/ebay-avatar
Storybook: http://opensource.ebay.com/ebayui-core-react/avatar/index.html?path=/docs/graphics-icons-ebay-avatar--docs
#309