This repository was archived by the owner on Apr 28, 2025. It is now read-only.
feat(avatar): added fit modifier #2565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agliga
requested review from
ArtBlue,
HenriqueLimas,
LuLaValva,
ianmcburnie and
saiponnada
🦋 Changeset detectedLatest commit: dc9efe8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ArtBlue
suggested changes
Feb 11, 2025
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2539
Description
image-treatmentto avatar (this changes the default color, but is still usable)avatar--fitmodifier to allow the image to fit the contents. For making the behavior happen automatically, we can look into adding this into coreui to detect the image aspect ratioScreenshots
Checklist
I verify the build is in a non-broken state
I verify all changes are within scope of the linked issue
I regenerated all CSS files under dist folder
I tested the UI in all supported browsers
I did a visual regression check of the components impacted by doing a Percy build and approved the build
I tested the UI in dark mode and RTL mode
I added/updated/removed Storybook coverage as appropriate