Add the property free to the class Parameter as an alias for not fixed
#82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSazonov
added
the
[scope] enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andped10
approved these changes
Oct 29, 2024
src/easyscience/Objects/Variable.py
Outdated
| min: Optional[numbers.Number] = -np.inf, | ||
| max: Optional[numbers.Number] = np.inf, | ||
| fixed: Optional[bool] = False, | ||
| free: Optional[bool] = True, |
Contributor
There was a problem hiding this comment.
To me it seems like this is not used and I would delete it. Also, it is probably dangerous both to fixed and free since they are mutual exclusive
| min: Optional[numbers.Number] = -np.inf, | ||
| max: Optional[numbers.Number] = np.inf, | ||
| fixed: Optional[bool] = False, | ||
| free: Optional[bool] = True, |
Contributor
There was a problem hiding this comment.
To me it seems like this is not used and I would delete it. Also, it is probably dangerous both to fixed and free since they are mutual exclusive
AndrewSazonov
force-pushed
the
free-params
branch
from
3932e13 to
f5e6501
Compare
AndrewSazonov
force-pushed
the
free-params
branch
from
f5e6501 to
e2c3c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in implementing the property
freefor the classParameter, in line with our discussion #20 as well as the issue #24.For now, the property
freehas been added as an alias tonot fixed.