Skip to content

Add the property free to the class Parameter as an alias for not fixed #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewSazonov merged 2 commits into from
Oct 29, 2024
Merged

Add the property free to the class Parameter as an alias for not fixed #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca852af
Add a `free` alias for parameters that are not `fixed`
AndrewSazonov Oct 14, 2024
e2c3c4b
Changes following the PR review
AndrewSazonov Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/easyscience/Objects/Variable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,6 +721,14 @@ def fixed(self, value: bool):
raise ValueError
self._fixed = value

@property
def free(self) -> bool:
return not self.fixed

@free.setter
def free(self, value: bool) -> None:
self.fixed = not value

@property
def error(self) -> float:
"""
Expand Down
8 changes: 8 additions & 0 deletions src/easyscience/Objects/new_variable/parameter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,14 @@ def fixed(self, fixed: bool) -> None:
raise ValueError(f'{fixed=} must be a boolean. Got {type(fixed)}')
self._fixed = fixed

@property
def free(self) -> bool:
return not self.fixed

@free.setter
def free(self, value: bool) -> None:
self.fixed = not value

@property
def bounds(self) -> Tuple[numbers.Number, numbers.Number]:
"""
Expand Down