Skip to content

[SPIKE] Ember 2.12#461

Closed
GavinJoyce wants to merge 19 commits intomasterfrom
gj/get-owner
Closed

[SPIKE] Ember 2.12#461
GavinJoyce wants to merge 19 commits intomasterfrom
gj/get-owner

Conversation

@GavinJoyce
Copy link
Collaborator

@GavinJoyce GavinJoyce commented Feb 8, 2018

part of #462

Working on making the tests pass, currently 97 are passing and the rest are commented out:

screen shot 2018-02-08 at 13 10 20

To run locally:

  • grunt develop
  • load http://localhost:8000/tests/?notrycatch=true

TODO:

  • make all tests pass
  • run a codemod on tests to update to QUnit 2 style
  • fix grunt test - likely due to QUnit upgrade
  • fix CI (seems to have started failing recently - https://travis-ci.org/ebryn/ember-model/builds)
  • fix Fatal error: grunt.util._.contains is not a function when running grunt develop
  • update expectAssertion helper and uncomment tests that use it
  • refactor
  • address any low hanging deprecations
  • can we split this PR up into smaller ones?

@GavinJoyce GavinJoyce changed the title [WIP] use getOwner API [WIP] Ember 2.12 Feb 8, 2018
@GavinJoyce GavinJoyce mentioned this pull request Feb 8, 2018
9 tasks
@GavinJoyce GavinJoyce changed the title [WIP] Ember 2.12 [SPIKE] Ember 2.12 Feb 13, 2018
@GavinJoyce
Copy link
Collaborator Author

Closing in favour of #465

@GavinJoyce GavinJoyce closed this Feb 13, 2018
@GavinJoyce GavinJoyce deleted the gj/get-owner branch February 13, 2018 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant