Closed
Conversation
This was referenced Feb 13, 2018
Closed
GavinJoyce
force-pushed
the
gj/ember-2.12
branch
2 times, most recently
from
307a709 to
06a1b7a
Compare
GavinJoyce
force-pushed
the
gj/ember-2.12
branch
from
06a1b7a to
a012216
Compare
Collaborator
Author
|
closing in favour of #473 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #462
Some tests seem to currently fail with
grunt test, but not withgrunt develop. This may be due to our use of legacy phantomjs. We're planning to remove that tomorrow, so I'll ignore those errors for now