Skip to content

ember 2.18.2#473

Merged
GavinJoyce merged 1 commit intomasterfrom
gj/ember-2.18.2
Apr 16, 2018
Merged

ember 2.18.2#473
GavinJoyce merged 1 commit intomasterfrom
gj/ember-2.18.2

Conversation

@GavinJoyce
Copy link
Collaborator

@GavinJoyce GavinJoyce commented Feb 22, 2018

Part of #462

This PR upgrades ember-model to use Ember 2.18.2. In order to minimise changes, I've tried to replicate the previous container logic with getOwner and setOwner.

TODO:

@GavinJoyce
Copy link
Collaborator Author

I cut a custom build based on our Intercom fork and it seems to work well in dev:

screen shot 2018-02-22 at 11 23 34

@GavinJoyce GavinJoyce mentioned this pull request Feb 27, 2018
@GavinJoyce GavinJoyce merged commit f6ff799 into master Apr 16, 2018
@GavinJoyce GavinJoyce deleted the gj/ember-2.18.2 branch April 16, 2018 07:59
@GavinJoyce GavinJoyce mentioned this pull request Apr 16, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant