Merged
Conversation
Collaborator
Author
|
/cc @paddyobrien @patocallaghan it would be good to get some eyes on this before merging |
paddyobrien
approved these changes
Feb 26, 2018
paddyobrien
left a comment
paddyobrien
left a comment
There was a problem hiding this comment.
We've been running this patch for a long time so I'm pretty happy it's good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #454 and rebased
part of #462
This PR allows ember-model and ember-data to coexist. We've been running these changes in our production app in Intercom for 12 months without issue: intercom#7
This change brings breaking changes:
I think we should accept these breaking changes and release a new major version. We're close to upgrading ember-model to Ember 2.18.2 so I think this will be a good opportunity to release a
2.18.0version of ember-model which will contain both changes. We can then follow up with a3.0release which will bring compatibility with Ember 3./cc @eventualbuddha
/cc @nolaneo as this is your work