fix(core): exclude empty tools array from DashScope API requests#3
Open
fix(core): exclude empty tools array from DashScope API requests#3
Conversation
…n matching Fixes QwenLM#1760 Windows file system is case-insensitive (e:\work equals E:\work), but string hashing is case-sensitive, causing different session directories for the same physical path. Solution: normalize paths to lowercase on Windows before hashing to ensure consistent session directory across different case variations.
Ensures consistent Windows path normalization across all path hashing. Previously Storage used its own getFilePathHash() which didn't apply Windows lowercase normalization, causing test failures on Windows CI.
- Add HTML template for insights display. - Create JavaScript application logic for rendering insights. - Introduce CSS styles for layout and design. - Develop a test generator for validating the static insight generator. - Define TypeScript interfaces for structured insight data. - Refactor insight command to generate insights and open in browser. - Remove the need for a server process by generating static files directly.
- Refine DataProcessor and StaticInsightGenerator logic - Update StaticInsightTypes definitions - Enhance insight command implementation - Update package dependencies
- Single-line layout with muted bar, accent stage text - Inline Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>... in stage messages for cleaner code - Simplify command intro text
- 将 ModelDialog.test.tsx 中的 MAINLINE_CODER_MODEL 替换为 DEFAULT_QWEN_MODEL - 修复 modelConfigResolver.test.ts 中 OpenAI auth 类型的默认模型期望 - 统一使用 core 包导出的 MAINLINE_CODER_MODEL 常量 Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Add backupSettingsFile() utility to create .orig backup before modifying settings - Update success message to indicate backup was created - Sync i18n translations for all supported languages - Update documentation to reflect the change Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Moves export-html and insight templates from cli/assets to a new dedicated web-templates package. Updates Dockerfile and build scripts to use consolidated bundle/prepare:package/pack workflow. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Remove unused npmCommand variable from build.mjs - Add no-undef and .mjs file support to web-templates eslint config Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
chore: bump version to 0.11.0
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
feat: Add insight command for personalized programming insights
The test 'blocks write tools in plan mode' was failing because the model would attempt to exit plan mode via exit_plan_mode tool. By cancelling switch_mode tool calls in the permission handler, we ensure plan mode stays active throughout the test. Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
fix(test): keep plan mode active during ACP integration test
- Update integration test environment variable name - Ensure sandbox container naming works correctly with new variable Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Corrected the file path in commands.md mapping table from '<project>/commands/git/commit.md' to '<project>/.qwen/commands/git/commit.md' - Removed trailing blank line in sandbox.md code block Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
docs: fix documentation errors in commands and model-providers - 测试通过 `<project>/git/commit.md` → `<project>/.qwen/commands/git/commit.md)` - 修复 develoers/sandbox 文档格式显示问题,代码块显示混乱
Merge coder-model and qwen3.5-plus, remove vision auto-switching
Rename GEMINI_CLI_INTEGRATION_TEST to QWEN_CODE_INTEGRATION_TEST and refactor sandbox user handling
feat(auth): add automatic backup of settings.json before auth modification
…eFolders-capability fix: change workspaceFolders capability to boolean for LSP servers
…e-pr fix: unblock input after ESC cancel
- Add weighted tip system to make certain tips appear more frequently - Set /insight tip to weight 3 (3x more likely than regular tips) - Add i18n translations for the new tip across all supported languages - Add comprehensive unit tests for weighted tip selection Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
…sure feat(cli): Increase /insight feature exposure via weighted tips
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
chore: bump version to 0.11.1
Fixes QwenLM#2054 When tools array is empty, the DashScope API returns error about tools being too short. Changes: - Filter out empty tools arrays in addDashScopeCacheControl - Exclude tools from request spread to avoid overriding processed tools - Only include tools param when array has items Tested with 43 tests including new cases for empty and non-empty tools.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes QwenLM#2054
Problem
When using qwen ai model via Xcode26, the API returns error about tools array being too short.
This happens when the tools array is empty but still included in the request.
Solution
Changes
packages/core/src/core/openaiContentGenerator/provider/dashscope.ts:
packages/core/src/core/openaiContentGenerator/provider/dashscope.test.ts:
Testing
All 43 tests pass including 2 new test cases.