Quickfixes should be available at the line level#1908
Merged
rgrunber merged 1 commit intoeclipse-jdtls:masterfrom Nov 11, 2021
Merged
Quickfixes should be available at the line level#1908rgrunber merged 1 commit intoeclipse-jdtls:masterfrom
rgrunber merged 1 commit intoeclipse-jdtls:masterfrom
Conversation
snjeza
changed the title
snjeza
changed the title
snjeza
force-pushed
the
issue-2130
branch
4 times, most recently
from
9e5e9dd to
910bfce
Compare
Contributor
Author
|
test this please |
snjeza
force-pushed
the
issue-2130
branch
2 times, most recently
from
097a5d6 to
ad73823
Compare
Contributor
Author
|
@rgrunber @testforstephen I have updated the PR. |
testforstephen
approved these changes
Nov 10, 2021
Contributor
testforstephen
left a comment
testforstephen
left a comment
There was a problem hiding this comment.
Looks good. Just a minor comment on the unnecessary changes.
Contributor
Author
|
@fbricon @rgrunber @testforstephen I have updated the PR. |
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
Contributor
|
@snjeza I just noticed a critical bug/regression with this PR while testing something else: implement-quick-fix-bug.mp4It seems like the "Add unimplemented methods" quick fix (and possibly others) are duplicated for every unimplemented method, and it's also taking a long time to compute quick fixes because of that. Going back to the previous commit on master confirms that this bug was introduced with this PR. |
Contributor
Author
|
@0dinD Could you, please, create a new (regression) ticket. |
Contributor
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#2130
Requires redhat-developer/vscode-java#2166
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com