Quickfixes should be available at the line level#2166
Merged
rgrunber merged 1 commit intoredhat-developer:masterfrom Nov 11, 2021
Merged
Quickfixes should be available at the line level#2166rgrunber merged 1 commit intoredhat-developer:masterfrom
rgrunber merged 1 commit intoredhat-developer:masterfrom
Conversation
snjeza
force-pushed
the
issue-2130
branch
3 times, most recently
from
8faf616 to
ef5cd3e
Compare
rgrunber
approved these changes
Nov 9, 2021
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
This looks fine to me. Once we merge the LS side I think we can merge this also.
Collaborator
|
java.quickfix.showAt=problem|line |
Collaborator
Author
Fixed. |
Collaborator
Author
|
@fbricon @rgrunber @testforstephen I have updated the PR. |
fbricon
reviewed
Nov 10, 2021
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2130
Requires eclipse-jdtls/eclipse.jdt.ls#1908
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com