Skip to content

Conversation

@aschemmel-tech
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 8, 2025

The created documentation from the pull request is available at: docu-html

@PandaeDo PandaeDo self-requested a review September 4, 2025 08:01
@aschemmel-tech aschemmel-tech marked this pull request as ready for review September 4, 2025 11:08
@aschemmel-tech
Copy link
Contributor Author

Please also add your ideas/comments of how the output result of the tool should look like (e.g. just a list of work products or an attribute filled for each work product). Likewise how we use it, e.g. only in a PR and/or standalone with UIDs as input values.

marcmo pushed a commit to esrlabs/score that referenced this pull request Sep 8, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 8, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 8, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 8, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
@masc2023
Copy link
Contributor

masc2023 commented Sep 9, 2025

Please also add your ideas/comments of how the output result of the tool should look like (e.g. just a list of work products or an attribute filled for each work product). Likewise how we use it, e.g. only in a PR and/or standalone with UIDs as input values.

Propose to modify the image in the following way, just binary color-code, work products to be covered for impact analysis or not
impact_analysis_01 drawio

Further to add an example, how it could work iteratively
impact_analysis_02 drawio

Assuming applied the tool during an PR.
Compare also https://github.com/eclipse-score/process_description/blob/4a53e42cfc72927631606bbc7c744d5473b8d5ef/.github/ISSUE_TEMPLATE/3-change.yml
will introduce a light-weight impact analysis, so the impact analysis tool could be used only during PR

@aschemmel-tech
Copy link
Contributor Author

aschemmel-tech commented Sep 16, 2025

  • I think the picture on iterative following the links is helpful and I will add.
  • But I am not happy with the removal of direction. I do not think for example that when a Safety Analysis is updated (for example if during a review an additional failure mode is found) this has any impact on the Architecture. But the other way round it may have. Just to focus on the real impact.

@pahmann
Copy link
Member

pahmann commented Sep 18, 2025

After reading through the simplified view from Markus, and reading the comment on it from Alexander, I start understanding the original picture properly. It took me roughly 3 attempts to get an understanding. As this is a requirement put to the later tooling, I wonder, if the requirement may be to complex to treat. Maybe bring the original picture as proposed by Alexander combined with the example and visualizing the example can create clarity.

Phrasing an explicit statement in the requirements text that the tests do not need to be treated, will be a value add. I remember that in an audit it was mentioned that the illustrations are a support of the textual description, but with the explanations in the figure information is created, which is not in the text.

Copy link
Member

@pahmann pahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my separate general comment.
Actions:

  • The requirement should mention the role of testing/verification items. The "not needed, ..." - in the illustration also has to be stated as explicit text.
  • The drawing needs an example for clarity as proposed by Markus

masc2023 added a commit to esrlabs/score that referenced this pull request Sep 22, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 22, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-impact-analysis-definition branch from a74b3d4 to a12367a Compare September 23, 2025 11:55
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 23, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
@pahmann
Copy link
Member

pahmann commented Sep 23, 2025

@aschemmel-tech your latest changes combining text and illustrations help me a lot for a better understanding. Thank you so much. My findings are addressed.

@masc2023 masc2023 merged commit 25bb024 into main Sep 23, 2025
5 checks passed
@masc2023 masc2023 deleted the aschemmel-tech-impact-analysis-definition branch September 23, 2025 13:38
masc2023 added a commit to esrlabs/score that referenced this pull request Oct 8, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants