Skip to content

Conversation

@masc2023
Copy link
Contributor

@masc2023 masc2023 commented Sep 5, 2025

Fix audit findings, Align with Problem Resolution
Define issue template for change request
Remove links to score repo

Resolves: #53

@github-actions
Copy link

github-actions bot commented Sep 5, 2025

The created documentation from the pull request is available at: docu-html

@masc2023 masc2023 force-pushed the masc2023_update_chm branch 2 times, most recently from 879d867 to 939fb03 Compare September 7, 2025 14:19
marcmo pushed a commit to esrlabs/score that referenced this pull request Sep 8, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
@masc2023 masc2023 marked this pull request as ready for review September 8, 2025 06:15
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 8, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
@masc2023 masc2023 force-pushed the masc2023_update_chm branch from 939fb03 to 4a53e42 Compare September 8, 2025 06:50
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 8, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 8, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
Copy link
Member

@pahmann pahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intermediate review status submitted. Not all files reviewed so far. More comments will follow.

Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

@masc2023
Copy link
Contributor Author

@aschemmel-tech , thank you for the review, we need to agree on the final template, then I need further re-work, as examples must be adapted

body:
- type: dropdown
attributes:
label: Change Request Type
Copy link
Contributor

@aschemmel-tech aschemmel-tech Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we discussed the change request of @odra (eclipse-score/score#1740) - the question was risen if there may be also "other" change requests - because this one is not really fitting in those categories (it is more about updating the process). But maybe we were wrong to say this should be a Change Request as it should be a "Improvement"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would agree, Process updates should be taken as Improvement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep improvement template (for processes) seperate and link to it here in Change Mgt process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the link as comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

select field should not contain the link in the selection text. I would have expected this even in the guideline instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed, does not show up any more, add as comment in the description part and some comment in the guideline

@masc2023 masc2023 requested a review from PandaeDo as a code owner September 22, 2025 05:49
@masc2023 masc2023 force-pushed the masc2023_update_chm branch 2 times, most recently from ac55c92 to dd18b8a Compare September 22, 2025 09:01
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 22, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 22, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
pahmann
pahmann previously approved these changes Sep 23, 2025
Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last open topic, other findings resolved

Fix audit findings, Align with Problem Resolution
Define issue template for change request
Remove links to score repo

Resolves: #53
Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@masc2023 masc2023 merged commit a4593ea into main Sep 23, 2025
5 checks passed
@masc2023 masc2023 deleted the masc2023_update_chm branch September 23, 2025 11:51
masc2023 added a commit to esrlabs/score that referenced this pull request Sep 23, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
masc2023 added a commit to esrlabs/score that referenced this pull request Oct 8, 2025
update to reflect changes in process description
eclipse-score/process_description#167 and
eclipse-score/process_description#148

Resolves: eclipse-score#1310
Change-Id: I6a58c1f0c457c654230e01ffb30a179b1729bcf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EPIC: Change Management, ML2

4 participants