Update codebase to comply with up-spec 1.5.8 L1#39
Merged
neelam-kushwah merged 2 commits intoeclipse-uprotocol:mainfrom Jul 2, 2024
Merged
Update codebase to comply with up-spec 1.5.8 L1#39neelam-kushwah merged 2 commits intoeclipse-uprotocol:mainfrom
neelam-kushwah merged 2 commits intoeclipse-uprotocol:mainfrom
Conversation
|
Code coverage report is ready! 📈
|
Contributor
Author
|
@princemac, Would you mind taking a look at it? It has major changes, so I would really appreciate your feedback. |
matthewd0123
suggested changes
Jun 26, 2024
Contributor
matthewd0123
left a comment
matthewd0123
left a comment
There was a problem hiding this comment.
Looks great! Added a few comments, mostly just matching method docs with the arg names.
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
princemac
suggested changes
Jul 1, 2024
|
Code coverage report is ready! 📈
|
princemac
approved these changes
Jul 2, 2024
stevenhartley
requested changes
Jul 2, 2024
stevenhartley
left a comment
stevenhartley
left a comment
There was a problem hiding this comment.
minor code change is all I found
| Factories.UPROTOCOL.create(), | ||
| UMessageType.UMESSAGE_TYPE_RESPONSE, | ||
| ) | ||
| .with_priority(UPriority.UPRIORITY_CS4) |
There was a problem hiding this comment.
Suggested change
| .with_priority(UPriority.UPRIORITY_CS4) | |
| .with_priority(request.priority) |
Contributor
Author
There was a problem hiding this comment.
Fixed and added a test case to verify this scenario.
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
Co-Authored-By: Matthew D'Alonzo <matthewdalonzo@gmail.com>
|
Code coverage report is ready! 📈
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 1.5.8, we have implemented the following enhancements: