Skip to content

Conversation

@kascaks
Copy link
Contributor

@kascaks kascaks commented May 24, 2023

This PR contains an enhancement of tsx test to verify fix for #980

@vrubezhny
Copy link
Contributor

@kascaks Have you signed Eclipse CLA using the same e-mail address that was used for this PR? If not, please do sign it at https://accounts.eclipse.org/user/eca

@kascaks
Copy link
Contributor Author

kascaks commented May 24, 2023

@kascaks Have you signed Eclipse CLA using the same e-mail address that was used for this PR? If not, please do sign it at https://accounts.eclipse.org/user/eca

Can this be done without creating eclipse account?
Maybe via this clause of the CLA?
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it

@vrubezhny
Copy link
Contributor

@kascaks Normally we wouldn't merge without agreeing with the contributor agreement. What's the problem with creating an Eclipse.org account?

@kascaks
Copy link
Contributor Author

kascaks commented May 25, 2023

It's just that it seems like an overkill to have to create account to push 7 lines of code. But, I did try to do it. However, I'm getting error that "The email address you entered is not valid. Please contact webmaster..." :) So, really not such an easy task :)

@vrubezhny
Copy link
Contributor

It's just that it seems like an overkill to have to create account to push 7 lines of code. But, I did try to do it. However, I'm getting error that "The email address you entered is not valid. Please contact webmaster..." :) So, really not such an easy task :)

I believe the e-mails like *+*@users.noreply.github.com will never be accepted by eclipse.org, neither by most of the other services. Do you have another e-mail registered to try registering at Eclipse.org? (The PR is to be re-created with that other e-mail if accepted)

@mickaelistria
Copy link
Contributor

it seems like an overkill to have to create account to push 7 lines of code

It is, but there have been some legal arguments for less than that. The ECA allows mostly to avoid possible issue by making you clearly state you're OK to contribute this code under the license.

@waynebeaton Can you help @kascaks in succeeding to sign the ECA?

@kascaks
Copy link
Contributor Author

kascaks commented May 29, 2023

I managed to create account and I signed the agreement

@mickaelistria
Copy link
Contributor

@kascaks Thanks for signing the ECA, we'll do our best to merge it ASAP..
@vrubezhny license-check jobs are failing. is there some incompatibility between Maven/Tycho versions here?

@vrubezhny
Copy link
Contributor

vrubezhny commented May 30, 2023

@mickaelistria it looks like yes, latest tychoo snapshot makes the build to fail on building maven dependencies if maven <3.9 is used.

I tried to fix windowsPR and licence check to use maven 3.9.2, so windowsPR functionality is restored, but I can't make it for maven projects check action we depend on at the moment.

To make it clear - WindowsPR and licensecheck, for sure, fail when Maven v.3.8.7 and v.3.8.7 are used to build with tycho v.4.0.0-SNAPSHOT.
Locally I build using Maven v.3.9.0, Jenkins build currently uses Maven v.3.9.2 - all successfully
I've switched WindowsPR and NPM License Check to use Maven v.3.9.2, but the same approach doesn't work for License check / call-mvn-license-check / check-licenses job - we should either wait for Maven v. >=3.9.0 is used in GitActions or fix the upstream code actions.

@vrubezhny
Copy link
Contributor

@kascaks Thanks for your contribution!

@vrubezhny vrubezhny merged commit 6847a2c into eclipse-wildwebdeveloper:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants