-
Notifications
You must be signed in to change notification settings - Fork 74
Enhanced language server TSX test to verify functionality on xml notation #1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced language server TSX test to verify functionality on xml notation #1222
Conversation
|
@kascaks Have you signed Eclipse CLA using the same e-mail address that was used for this PR? If not, please do sign it at https://accounts.eclipse.org/user/eca |
Can this be done without creating eclipse account? |
|
@kascaks Normally we wouldn't merge without agreeing with the contributor agreement. What's the problem with creating an Eclipse.org account? |
|
It's just that it seems like an overkill to have to create account to push 7 lines of code. But, I did try to do it. However, I'm getting error that "The email address you entered is not valid. Please contact webmaster..." :) So, really not such an easy task :) |
I believe the e-mails like |
It is, but there have been some legal arguments for less than that. The ECA allows mostly to avoid possible issue by making you clearly state you're OK to contribute this code under the license. @waynebeaton Can you help @kascaks in succeeding to sign the ECA? |
|
I managed to create account and I signed the agreement |
5dddec6 to
f045644
Compare
|
@kascaks Thanks for signing the ECA, we'll do our best to merge it ASAP.. |
|
@mickaelistria it looks like yes, latest tychoo snapshot makes the build to fail on building maven dependencies if maven <3.9 is used. I tried to fix windowsPR and licence check to use maven 3.9.2, so windowsPR functionality is restored, but I can't make it for maven projects check action we depend on at the moment. To make it clear - WindowsPR and licensecheck, for sure, fail when Maven v.3.8.7 and v.3.8.7 are used to build with tycho v.4.0.0-SNAPSHOT. |
|
@kascaks Thanks for your contribution! |
This PR contains an enhancement of tsx test to verify fix for #980