Skip to content

list depth changes cherry picked from feature/list-depth-option#60

Closed
danovaro wants to merge 13 commits intomasterfrom
fix/list_depth
Closed

list depth changes cherry picked from feature/list-depth-option#60
danovaro wants to merge 13 commits intomasterfrom
fix/list_depth

Conversation

@danovaro
Copy link
Copy Markdown
Member

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@danovaro danovaro requested a review from tbkr October 29, 2025 08:20
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@5899803). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #60   +/-   ##
==========================================
  Coverage           ?   97.76%           
==========================================
  Files              ?        8           
  Lines              ?      402           
  Branches           ?        0           
==========================================
  Hits               ?      393           
  Misses             ?        9           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@ChrisspyB ChrisspyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me. Hopefully this will all soon be replaced by the pybind interface.

@tbkr
Copy link
Copy Markdown
Collaborator

tbkr commented Oct 29, 2025

I checked to code and LGTM. The tests are covering the new features and I tested install via pip (locally), which worked for me. As a heads-up: On develop there are the wipe and purge features, which we don't want to publish yet, so this should be applied as a hotfix to the master.

@danovaro danovaro changed the base branch from develop to master October 29, 2025 11:11
@danovaro
Copy link
Copy Markdown
Member Author

thanks @tbkr and @ChrisspyB.
It seems that master has been aligned with develop when we have merged the libaec version fix.
I'll release 0.1.3

@danovaro danovaro closed this Oct 29, 2025
@danovaro
Copy link
Copy Markdown
Member Author

created an hotfix cherry picking these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants