Merged
Conversation
Author
|
@neSpecc, @GoldenJaden @robonetphy Can a maintainer give me feedback about this pr?`Can it be merged or does it still need changes? Thank you very much. |
neSpecc
requested changes
Aug 6, 2024
neSpecc
approved these changes
Aug 7, 2024
Contributor
|
Thanks, @Sozialarchiv |
Author
|
Thank you for the review and merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds types that are automatically generated by the jsdoc comments. This are not perfect types, but a pragmatic way to solves the current types issue for the moment.