feat(JD-1/DS-314): Microsite aware key-secret pairs for oauth#698
Merged
Henrrypg merged 1 commit intoednx-release/nuez.masterfrom Nov 25, 2022
Merged
feat(JD-1/DS-314): Microsite aware key-secret pairs for oauth#698Henrrypg merged 1 commit intoednx-release/nuez.masterfrom
Henrrypg merged 1 commit intoednx-release/nuez.masterfrom
Conversation
- Change KEY_FIELD from KEY_FIELDS = ('backend_name') to KEY_FIELDS = ('site_id', 'backend_name')
- Override provider_id to cast field
- Override current method to pass site_id
686a74d to
4b2dd52
Compare
JuanDavidBuitrago
approved these changes
Nov 23, 2022
Member
JuanDavidBuitrago
left a comment
There was a problem hiding this comment.
It's working as expected
MaferMazu
approved these changes
Nov 25, 2022
Contributor
MaferMazu
left a comment
There was a problem hiding this comment.
It works, but I think it is important you update the documentation in favor of tenant configs instead of a microsite; the variable ENABLE_THIRD_PARTY_AUTH should be inside FEATURES (the doc doesn't reflect that); and in the PR you mention stack-builder, I think you can drop it because that setting can be placed in that file only with Tutor if you want. Can you update the documentation? Thanks in advance @Henrrypg ✨
Author
|
Thank you @MaferMazu, the doc and the PR is updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR allows us to create an Oauth2 configuration for each site with different backends, enabling multitenancy.
A more detailed description of these changes: #433
How to test
File: env/apps/openedx/settings/lms/development.py
Checkout this document on how to configure your Google provider
Before changes (optional)

With JD-1

If your site/provider is well configured then you'll be able to register and login to your site.