Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
- Coverage 100% 96.15% -3.85%
==========================================
Files 4 4
Lines 20 26 +6
==========================================
+ Hits 20 25 +5
- Misses 0 1 +1
Continue to review full report at Codecov.
|
dead-horse
force-pushed
the
feat-events
branch
from
ff3afff to
dbc6722
Compare
fengmk2
reviewed
Jan 9, 2018
app.js
Outdated
|
|
||
| // listen on session's events | ||
| app.on('session:missed', ({ ctx, key }) => { | ||
| ctx.logger.warn('[session][missed] key(%s)', key); |
fengmk2
approved these changes
Jan 9, 2018
dead-horse
force-pushed
the
feat-events
branch
from
dbc6722 to
ef31c28
Compare
dead-horse
added a commit
that referenced
this pull request
Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change