Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,15 @@

module.exports = function(app) {
app.config.coreMiddleware.push('session');

// listen on session's events
app.on('session:missed', ({ ctx, key }) => {
ctx.coreLogger.warn('[session][missed] key(%s)', key);
});
app.on('session:expired', ({ ctx, key, value }) => {
ctx.coreLogger.warn('[session][expired] key(%s) value(%j)', key, value);
});
app.on('session:invalid', ({ ctx, key, value }) => {
ctx.coreLogger.warn('[session][invalid] key(%s) value(%j)', key, value);
});
};
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"cookie"
],
"dependencies": {
"koa-session": "^5.5.0"
"koa-session": "^5.7.0"
},
"devDependencies": {
"autod": "^2.10.1",
Expand Down
17 changes: 17 additions & 0 deletions test/app/middleware/session.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,23 @@ describe('test/app/middlewares/session.test.js', () => {
});
after(() => app.close());

if (name === 'redis-session') {
it('should get with ', function* () {
yield agent
.get('/set?foo=bar')
.expect(200)
.expect({ foo: 'bar' })
.expect('set-cookie', /EGG_SESS=.*?;/);

mm.empty(app.redis, 'get');

yield agent
.get('/get')
.expect(200)
.expect({});
});
}

it('should get empty session and do not set cookie when session not populated', function* () {
yield agent
.get('/get')
Expand Down