Sort extracted styles using module import order#143
Closed
kendrickw wants to merge 1 commit intoegoist:masterfrom
kendrickw:extract-order
Closed
Sort extracted styles using module import order#143kendrickw wants to merge 1 commit intoegoist:masterfrom kendrickw:extract-order
kendrickw wants to merge 1 commit intoegoist:masterfrom
kendrickw:extract-order
Conversation
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
==========================================
+ Coverage 94.61% 94.73% +0.11%
==========================================
Files 8 8
Lines 223 228 +5
Branches 77 78 +1
==========================================
+ Hits 211 216 +5
Misses 12 12
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #96, and the solution is based heavily on the work by dnjstrom in #109
These changes correct the source ordering of the extracted styles in the minimal example from #108.
The rollup version in the devDependencies has been upgraded, so that the jest test would exercise the new code that has been added.