Skip to content

Sort extracted styles using module import order#143

Closed
kendrickw wants to merge 1 commit intoegoist:masterfrom
kendrickw:extract-order
Closed

Sort extracted styles using module import order#143
kendrickw wants to merge 1 commit intoegoist:masterfrom
kendrickw:extract-order

Conversation

@kendrickw
Copy link
Copy Markdown
Contributor

@kendrickw kendrickw commented Dec 14, 2018

This PR fixes #96, and the solution is based heavily on the work by dnjstrom in #109

These changes correct the source ordering of the extracted styles in the minimal example from #108.

The rollup version in the devDependencies has been upgraded, so that the jest test would exercise the new code that has been added.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2018

Codecov Report

Merging #143 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   94.61%   94.73%   +0.11%     
==========================================
  Files           8        8              
  Lines         223      228       +5     
  Branches       77       78       +1     
==========================================
+ Hits          211      216       +5     
  Misses         12       12
Impacted Files Coverage Δ
src/index.js 98.38% <100%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5168c12...2edd007. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS should be extracted in the order they've been imported

2 participants