Use generateBundle instead of onwrite#148
Merged
egoist merged 5 commits intoegoist:masterfrom Jan 22, 2019
sampi:rollup-1.x.x
Merged
Use generateBundle instead of onwrite#148egoist merged 5 commits intoegoist:masterfrom sampi:rollup-1.x.x
generateBundle instead of onwrite#148egoist merged 5 commits intoegoist:masterfrom
sampi:rollup-1.x.x
Conversation
Fixes #147 The `onwrite` rollup hook has been deprecated in favor of `generateBundle`. rollup/rollup#2409
|
Can you update the snapshots in the tests? |
Contributor
Author
|
@nathancahill hey, I did but something doesn't look ok, and the order of the css rules aren't deterministic. (no matter if I update the snapshots or not, it fails) I'll have to investigate a bit more. |
Contributor
|
PR #143 should fix the order of css rules, and make the order deterministics. However, with the new should become: |
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 94.61% 94.69% +0.07%
==========================================
Files 8 8
Lines 223 226 +3
Branches 77 79 +2
==========================================
+ Hits 211 214 +3
Misses 12 12
Continue to review full report at Codecov.
|
Owner
|
Thanks @kendrickw I fixed the module order in the PR. |
bung87
pushed a commit
to bung87/rollup-plugin-postcss
that referenced
this pull request
Dec 3, 2019
@egoist @lmihaidaniel Fixes egoist#147 The `onwrite` rollup hook has been deprecated in favor of `generateBundle` in `rollup@1.x.x`. rollup/rollup#2409
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@egoist @lmihaidaniel
Fixes #147
The
onwriterollup hook has been deprecated in favor ofgenerateBundleinrollup@1.x.x. rollup/rollup#2409