SubSync v1.0.1: exception filter, DTO hardening, dashboard spend fix, API consolidation, test fixes#2
Draft
SubSync v1.0.1: exception filter, DTO hardening, dashboard spend fix, API consolidation, test fixes#2
Conversation
…rd spend fix, API consolidation, test fixes Co-authored-by: ejames-dev <180847219+ejames-dev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Suggest improvements for version 1.0.1 of SubSync
SubSync v1.0.1: exception filter, DTO hardening, dashboard spend fix, API consolidation, test fixes
Mar 19, 2026
ejames-dev
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles several targeted v1.0.1 improvements across the API and web layers.
API
Global exception filter
Added
HttpExceptionFilter(@Catch()) registered inmain.ts. All errors now emit a uniform{ statusCode, message, error }envelope. Unexpected runtime errors are caught, logged with stack traces via NestJSLogger, and returned as clean 500s.DTO validation hardening
CreateSubscriptionDto:@MaxLengthonserviceId(100),planName(150),billingCurrency(3),paymentLast4(4),notes(1,000);paymentSourcetightened from@IsString→@IsIn(['card','paypal','gift','other']).UpdateSettingsDto:@Max(365)added to previously unboundedleadTimeDays.EmailIngestPayload:@MaxLength(50000)onbody.Dashboard spend calculation
canceled_pendingsubscriptions now excluded frommonthlyEquivalentSpendandspendByCategory. These are already canceled and were silently inflating ongoing cost totals.Web
API layer consolidation
subscription-form.tsxwas making rawfetchcalls with duplicated base-URL resolution. AddedupdateSubscription(id, payload)toapi.tsand refactored the form to use the typed helpers (createSubscription,updateSubscription,deleteSubscription).Tests
subscriptions.service.spec.tshad two bugs that prevented the suite from running correctly:ServiceCatalogServicewas missing from the constructor call — would throwTypeErrorat runtime.billingAmount: new Prisma.Decimal(15)instead of the actual schema fieldbillingAmountCents: 1500.All 5 unit tests now pass.
Misc
1.0.1.docs/release-notes-v1.0.1.mdadded.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.