fix: add NO_PROXY to test_vm_uses_ipv6_proxy to bypass proxy for registry#218
Closed
claude-claude[bot] wants to merge 1 commit intohttp-proxyfrom
Closed
fix: add NO_PROXY to test_vm_uses_ipv6_proxy to bypass proxy for registry#218claude-claude[bot] wants to merge 1 commit intohttp-proxyfrom
claude-claude[bot] wants to merge 1 commit intohttp-proxyfrom
Conversation
…stry The test_vm_uses_ipv6_proxy test was failing because it set a fake IPv6 proxy URL (using the host's global IPv6 address) but this caused podman inside the VM to try using that proxy for pulling alpine:latest. The pull failed with 'network is unreachable' because the VM cannot directly reach the host's global IPv6 address - slirp4netns IPv6 NAT doesn't make host global IPs directly accessible. The test only needs to verify that proxy env vars are passed to the VM, not that the proxy actually works. The fix sets NO_PROXY/no_proxy to exclude Docker registries from proxy usage, allowing image pulls to succeed while still testing that proxy environment variables are correctly propagated. Fixes CI failure in test_vm_uses_ipv6_proxy and related proxy/IPv6 tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
7 tasks
Owner
|
Superseded by complete test rewrite in PR #217. The old test using fake proxy URLs has been replaced with matrix tests that spin up actual proxy servers and verify requests go through them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
Fixes CI #21640014575
Problem
The
test_vm_uses_ipv6_proxytest (and related IPv6/proxy tests) were failing because:http://[<host-ipv6>]:9999alpine:latestnetwork is unreachablebecause the VM cannot reach the host's global IPv6 addressError from logs:
Solution
Added
NO_PROXY/no_proxyenvironment variables to exclude Docker registries (registry-1.docker.io,docker.io) from proxy usage.This allows:
The test's purpose (per its comments) is to verify proxy environment variable propagation, NOT to test actual proxy functionality.
Testing
The fix ensures:
alpine:latestpulls succeed without using the proxyGenerated by Claude | Fix Run