Skip to content

fix: add NO_PROXY to test_vm_uses_ipv6_proxy to bypass proxy for registry #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
claude-claude wants to merge 1 commit into from
Closed

fix: add NO_PROXY to test_vm_uses_ipv6_proxy to bypass proxy for registry #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/test_proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ async fn test_vm_uses_ipv6_proxy() -> Result<()> {

println!("Starting VM with proxy env: {}", proxy_url);

// Set NO_PROXY to exclude the Docker registry from proxy usage
// This allows the test to verify proxy env vars are passed while still allowing image pulls to succeed
let no_proxy = "registry-1.docker.io,docker.io";

// Start VM with proxy env vars (no image pull through proxy - use alpine which should be cached)
let (mut child, pid) = common::spawn_fcvm_with_env(
&[
Expand All @@ -70,7 +74,12 @@ async fn test_vm_uses_ipv6_proxy() -> Result<()> {
"sleep",
"infinity",
],
&[("http_proxy", &proxy_url), ("https_proxy", &proxy_url)],
&[
("http_proxy", &proxy_url),
("https_proxy", &proxy_url),
("no_proxy", no_proxy),
("NO_PROXY", no_proxy),
],
)
.await
.context("spawn fcvm with proxy env")?;
Expand Down
Loading