fix: slirp stderr diagnostics, e2fsck signal default, stale README ref#271
Closed
claude-claude[bot] wants to merge 1 commit intoreview-fixesfrom
Closed
fix: slirp stderr diagnostics, e2fsck signal default, stale README ref#271claude-claude[bot] wants to merge 1 commit intoreview-fixesfrom
claude-claude[bot] wants to merge 1 commit intoreview-fixesfrom
Conversation
… default, remove stale README ref 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-Fix for PR #268
Issues Fixed
Stdio::piped()while keeping stdout asStdio::null(). The error path at line 365 callswait_with_output()to capture stderr when slirp4netns dies at startup — withStdio::null()this always produced an empty/unhelpful error message. Stderr is only read after the process exits, so there's no deadlock risk.unwrap_or(1)→unwrap_or(8)so signal-killed e2fsck processes are treated as fatal errors instead of silently passing the>= 4check.FCVM_NO_XATTR_FASTPATHenv var documentation since the xattr fast-path was removed in PR Fix 21 bugs from codebase review (Waves 1+2) #268.Changes
src/network/slirp.rs:Stdio::null()→Stdio::piped()for stderr onlysrc/storage/disk.rs:unwrap_or(1)→unwrap_or(8)README.md: Removed staleFCVM_NO_XATTR_FASTPATHrow from env var tableGenerated by Claude | Review Run