Skip to content

fix: slirp stderr diagnostics, e2fsck signal default, stale README ref #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
claude-claude wants to merge 1 commit into from
Closed

fix: slirp stderr diagnostics, e2fsck signal default, stale README ref #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,6 @@ See [DESIGN.md](DESIGN.md#guest-agent) for details.
| `RUST_LOG` | `warn` | Logging level (quiet by default; use `info` or `debug` for verbose) |
| `FCVM_NO_SNAPSHOT` | unset | Set to `1` to disable automatic snapshot creation (same as `--no-snapshot` flag) |
| `FCVM_NO_WRITEBACK_CACHE` | unset | Set to `1` to disable FUSE writeback cache (see below) |
| `FCVM_NO_XATTR_FASTPATH` | unset | Set to `1` to disable security.capability xattr fast path |

### FUSE Writeback Cache

Expand Down
2 changes: 1 addition & 1 deletion src/network/slirp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ ip addr add {namespace_ip}/24 dev {bridge}
.arg(&self.slirp_device)
.stdin(Stdio::null())
.stdout(Stdio::null())
.stderr(Stdio::null());
.stderr(Stdio::piped());

let child = cmd.spawn().context("failed to spawn slirp4netns")?;

Expand Down
2 changes: 1 addition & 1 deletion src/storage/disk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ pub async fn ensure_free_space(

// e2fsck exit codes: 0=clean, 1=corrected, 2=corrected+reboot needed
// Exit code >= 4 means uncorrected errors
if e2fsck_output.status.code().unwrap_or(1) >= 4 {
if e2fsck_output.status.code().unwrap_or(8) >= 4 {
bail!(
"e2fsck found uncorrectable errors: {}",
String::from_utf8_lossy(&e2fsck_output.stderr)
Expand Down
Loading