fix: retry HTTP request in clone bench for pasta networking readiness#538
Closed
claude-claude[bot] wants to merge 1 commit intorouted-mode-fixesfrom
Closed
fix: retry HTTP request in clone bench for pasta networking readiness#538claude-claude[bot] wants to merge 1 commit intorouted-mode-fixesfrom
claude-claude[bot] wants to merge 1 commit intorouted-mode-fixesfrom
Conversation
The clone.rs benchmark's clone_http() method made a single HTTP request immediately after snapshot restore, but pasta networking may need a moment to establish L4 translation after clone restore. This caused empty responses and panics on both x64 and arm64 CI. The exec.rs benchmark already had the correct retry logic (10 attempts with 500ms delays). Apply the same pattern to clone.rs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Superseded by fixes in #536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
Fixes CI #22563426195
Problem
The
clone.rsbenchmark'sclone_http()method made a single HTTP request immediately after snapshot restore, but pasta networking needs a moment after clone restore to establish L4 translation. This caused empty HTTP responses and panics in theclone/http/nginxtest on both x64 and arm64 CI (Host-Root-x64-SnapshotEnabledandHost-Root-arm64-SnapshotEnabled).The error was:
Solution
Applied the same retry logic already present in
exec.rs'sclone_http()method: retry HTTP requests up to 10 times with 500ms delays to allow pasta networking to establish L4 translation after clone restore. This is not a timeout increase — it handles a known race condition where the pasta networking layer isn't immediately ready after snapshot restore.The
exec.rsbenchmark already had this fix with the comment:Root Cause
The
clone.rsandexec.rsbenchmarks both have aCloneFixturewith aclone_http()method, but they were not kept in sync. Whenexec.rswas updated with retry logic for the pasta networking race,clone.rswas not updated.Generated by Claude | Fix Run