Skip to content

fix: retry HTTP request in clone bench for pasta networking readiness #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
claude-claude wants to merge 1 commit into from
Closed

fix: retry HTTP request in clone bench for pasta networking readiness #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 26 additions & 23 deletions benches/clone.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,31 +263,34 @@ impl CloneFixture {
std::thread::sleep(Duration::from_millis(50));
};

// Make HTTP request to nginx
// verify_port_forwarding() runs after snapshot restore and confirms end-to-end
// data flow through pasta before health monitor starts.
// Make HTTP request to nginx (retry briefly — pasta networking may need
// a moment after clone restore to establish L4 translation)
let addr = format!("{}:{}", loopback_ip, health_port);
let mut stream = TcpStream::connect(&addr).expect("failed to connect to nginx");
stream
.set_read_timeout(Some(Duration::from_secs(5)))
.unwrap();
stream
.set_write_timeout(Some(Duration::from_secs(5)))
.unwrap();

let request = "GET / HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n";
stream
.write_all(request.as_bytes())
.expect("failed to send HTTP request");

let mut response = Vec::new();
let _ = stream.read_to_end(&mut response);

let response_str = String::from_utf8_lossy(&response);
if !response_str.contains("200 OK") {
let mut last_response = String::new();
let mut http_ok = false;
for attempt in 0..10 {
if attempt > 0 {
std::thread::sleep(Duration::from_millis(500));
}
if let Ok(mut stream) = TcpStream::connect(&addr) {
stream.set_read_timeout(Some(Duration::from_secs(2))).ok();
stream.set_write_timeout(Some(Duration::from_secs(2))).ok();
let request = "GET / HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n";
if stream.write_all(request.as_bytes()).is_ok() {
let mut response = Vec::new();
let _ = stream.read_to_end(&mut response);
last_response = String::from_utf8_lossy(&response).to_string();
if last_response.contains("200 OK") {
http_ok = true;
break;
}
}
}
}
if !http_ok {
panic!(
"unexpected HTTP response: {}",
&response_str[..std::cmp::min(200, response_str.len())]
"unexpected HTTP response after 10 attempts: {}",
&last_response[..std::cmp::min(200, last_response.len())]
);
}

Expand Down
Loading